Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop rigid boat hull breaking into pliable fabric sheets #63122

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

cake-pie
Copy link
Contributor

Summary

Bugfixes "Stop rigid boat hull breaking into pliable fabric sheets"

Purpose of change

The vehicle part carbonfiber_boat_hull built using item of same id is of material kevlar_rigid but breaks into whole sheets of pliable kevlar fabric sheet_kevlar.

"breaks_into": [ { "item": "sheet_kevlar", "count": [ 1, 3 ] } ],

Such rigid kevlar material is made from multiple layers that have been bonded (with epoxy resin IRL; superglue in-game) and should not delaminate into intact sheets.

Describe the solution

Change outcome to rigid Kevlar plate rigid_kevlar_plate which corresponds to material kevlar_rigid.

Add word "rigid" to the item description (compare: plastic_boat_hull is "A rigid plastic sheet that keeps the boat afloat."); this is to emphasize that it is of rigid construction, not "skin-on-frame".

Describe alternatives you've considered

  • More damage, smaller pieces: requires creating a new item that smaller sized version of rigid_kevlar_plate.
  • Total obliteration: instead of rigid plates or intact sheets, only scraps of Kevlar fabric scrap_kevlar remain.

Testing

Checked valid json.
Unfortunately, smashing a racing kayak to bits with a sledgehammer in game tends to break the frame before the hull part.

Additional context

This PR does not attempt to fix the mismatch in weight of maximum breaks_into output vs the part itself, which dates back a long way. carbonfiber_boat_hull has weighed 500g ever since it was added, but the breaks_into output has varied, and most probably has never come anywhere close to matching the item weight:

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions astyled astyled PR, label is assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 15, 2023
@bombasticSlacks bombasticSlacks merged commit 8c8c9fc into CleverRaven:master Mar 2, 2023
@cake-pie cake-pie deleted the rigidboat branch March 2, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants