Stop rigid boat hull breaking into pliable fabric sheets #63122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Stop rigid boat hull breaking into pliable fabric sheets"
Purpose of change
The vehicle part
carbonfiber_boat_hull
built using item of same id is of materialkevlar_rigid
but breaks into whole sheets of pliable kevlar fabricsheet_kevlar
.Cataclysm-DDA/data/json/vehicleparts/vehicle_parts.json
Line 1132 in 583923e
Such rigid kevlar material is made from multiple layers that have been bonded (with epoxy resin IRL; superglue in-game) and should not delaminate into intact sheets.
Describe the solution
Change outcome to rigid Kevlar plate
rigid_kevlar_plate
which corresponds to materialkevlar_rigid
.Add word "rigid" to the item description (compare:
plastic_boat_hull
is "A rigid plastic sheet that keeps the boat afloat."); this is to emphasize that it is of rigid construction, not "skin-on-frame".Describe alternatives you've considered
rigid_kevlar_plate
.scrap_kevlar
remain.Testing
Checked valid json.
Unfortunately, smashing a racing kayak to bits with a sledgehammer in game tends to break the frame before the hull part.
Additional context
This PR does not attempt to fix the mismatch in weight of maximum
breaks_into
output vs the part itself, which dates back a long way.carbonfiber_boat_hull
has weighed 500g ever since it was added, but thebreaks_into
output has varied, and most probably has never come anywhere close to matching the item weight:kevlar_plate
@ 360g each when added in vehicles: add support for amphibious vehicles #27251kevlar_plate
@ 300g each just before Rework kevlar, add slash resistant and EOD gear #39964sheet_kevlar
@ 5g each just after Rework kevlar, add slash resistant and EOD gear #39964sheet_kevlar
@ 26g each as of this writing (583923e)rigid_kevlar_plate
@ 429g each after this PR