Amphibian Additions - Phase 1 - Non-Monstrous Frogs, Toads, and Treefrogs

[TheSaddestGoomba]

Summary

Content "Add diversity to amphibian species to reflect other animal varieties in game and set space to expand monstrous amphibian mutants (and their zombified remains)."

Purpose of change

Add more specific natural species that function like wildlife and expand mutant varieties beyond size-growth.
Expounded on and first implementation of #67029

Describe the solution

Adds 6 new frog species, a strange (non-monstrous) version of each, and tadpoles and eggs for all 12 varieties.
The strange versions are for flavor and potential future development where they will progress into more mutated species.

Describe alternatives you've considered

Removing the existing frog, toad, and tadpoles. I still intend to eventually. My previous attempt to work them into this PR broke something so I simply worked around them and have left them for the time being.
This is done in the newest commit. Everything looks clean from my initial test.

Spawns and group weights still need a lot of testing and adjustment.
These have been updated and I'm happy with the current balance.

Create a weakpoints set for frog-a-forms and/or unique harvest results/items/descriptions. Neither seems very relevant with these little fellers. I expect to add them in the future with mutants the player might actually fight.

Testing

Created a world and character, teleported around checking spawns. Frog and tadpole varieties appear to be spawning in desired locations. Old entities are completely absent and the number and placement of new species feels appropriate.

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• Based on its vestigial tail, you might call it a polliwog. That is if it weren't so large and didn't already move like an adult frog. In any case, it looks to have some growing left to do.
• This large frog is covered in chaotic markings like a fractal river map over a background of tv static.
• This treefrog can change its coloration much like a chameleon, shifting from a near-white gray, through greens and browns, to a dark, almost charcoal color.
• gray treefrog
• gray treefrogs
• shifting treefrog
• shifting treefrogs
• vocal treefrog
• vocal treefrogs

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

[Karol1223]

Not entirely sure what's going on with test failures but it looks like you have issues with the mods since you removed normal frogs and toads. On top of my head this breaks Tameable Wildlife, I'd assume TropiCata is affected as well but you should double check all the mods to see if they don't reference things you just removed.

On top of that, and I only realized it now, you're removing the eggs instead of obsoleting them which will cause errors on any saves that have those items. Either migrate them or obsolete them, please.

[TheSaddestGoomba]

Sorry about that. The newest commit restores all of the deleted entries flagged and sorted for obsoletion. If I understand correctly, mods will still be able to call to the entries from the obsoletion folder. That should fix any issues of dead references, though Tamable Wildlife would need a future PR for the new species.
The old entities have already been removed from all monstergroups in mainline so shouldn't spawn there.
I think that should leave everything sorted now.

[Karol1223]

Don't obsolete monsters. We don't do that. They'll just turn to breathers silently.

And please don't just assume someone will make a PR to fix it for mod content, this will just break when we remove obsolete entries after next stable. Really this should be handled here. Yes, I know this can be annoying. You could hope it gets merged without that but it's a bad practice.

[TheSaddestGoomba]

Ah ok, monsters were listed among other categories in the documentation. That would explain why there were none already in the folder. So is the solution for monsters to simply remove them from spawning? If so, I can remove the obsolete flag from the 4 monsters and move them back to reptiles_amphibians.json and that should fix the mod issues.

To clarify, I'm referring to making the new creatures tamable in a future PR, not fixing the errors. I wasn't assuming someone else would do that, I intend to.
I don't mind including the mod integration in this one, and I don't find it annoying; it will simply take more time.
I do however think it's a large barrier to contributing if any new creature addition is expected to also be integrated into mod features out the gate.

[Karol1223]

Ah ok, monsters were listed among other categories in the documentation. That would explain why there were none already in the folder. So is the solution for monsters to simply remove them from spawning? If so, I can remove the obsolete flag from the 4 monsters and move them back to reptiles_amphibians.json and that should fix the mod issues.

Just remove the monsters entirely. No obsoletion, no moving around. Just remove them completely - them not needing obsoletion is a relatively new thing. If they're unused you should definitely not keep them around, much less so in a normal file.

Realistically you should just remove those and fix the mod conflicts in the mod files and then it should be good to go. Keeping unused content in mainline to fix mod errors isn't the way to go.

I do however think it's a large barrier to contributing if any new creature addition is expected to also be integrated into mod features out the gate.

Integration isn't necessary for anything, I am only talking about fixing the mod conflicts. Tameable Wildlife has its own monsters that copy from vanilla monsters you removed. You should either remove them from Tameable Wildlife as well or make them copy from your replacements you introduced here. Having said that - other mods have errors, too. I think TropiCata animals copy from the amphibians you removed as well. Hence your test errors. Integrating things into mods isn't a necessity, I think we just had a misunderstanding in what we were talking about here.

[TheSaddestGoomba]

Just remove the monsters entirely. No obsoletion, no moving around. Just remove them completely - them not needing obsoletion is a relatively new thing. If they're unused you should definitely not keep them around, much less so in a normal file.

Realistically you should just remove those and fix the mod conflicts in the mod files and then it should be good to go. Keeping unused content in mainline to fix mod errors isn't the way to go.

Integration isn't necessary for anything, I am only talking about fixing the mod conflicts. Tameable Wildlife has its own monsters that copy from vanilla monsters you removed. You should either remove them from Tameable Wildlife as well or make them copy from your replacements you introduced here. Having said that - other mods have errors, too. I think TropiCata animals copy from the amphibians you removed as well. Hence your test errors.

Ok, I've done all of that that in the latest commit. Old monsters have been removed entirely.
I believe I got everything in TropiCata and Tamable Wildlife updated with new references. Megafauna also had some references to mon_frog in monstergroups.

Integrating things into mods isn't a necessity, I think we just had a misunderstanding in what we were talking about here.

I think so, sorry for my part in it.

[Karol1223]

Looks good to me so if the tests pass this looks acceptable

[Karol1223]

Right that's an awkward test to fail. Your PR Summary isn't written correctly. You only have the context in ", without the word prefix you gotta choose from

[TheSaddestGoomba]

Ok, I think that's all that was needed