-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Magiclysm] Potion fruits! #67840
Merged
Merged
[Magiclysm] Potion fruits! #67840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @GuardianDll
github-actions
bot
added
the
astyled
astyled PR, label is assigned by github actions
label
Aug 23, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Cool idea! |
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Aug 24, 2023
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 24, 2023
github-actions
bot
added
BasicBuildPassed
This PR builds correctly, label assigned by github actions
and removed
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Aug 24, 2023
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 25, 2023
github-actions
bot
added
the
Code: Tests
Measurement, self-control, statistics, balancing.
label
Aug 25, 2023
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Code: Tests
Measurement, self-control, statistics, balancing.
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "Add potion fruits and recipes to make them"
Purpose of change
If magic has existed since prehistoric times, there must be prehistoric magic techniques.
Describe the solution
Adds "potion fruits," simple recipes that just need fruit and crystallized mana. They have various small effects--an apple potion fruit heals a bit of damage, a handful of grape potion fruits cures intoxication, a pear potion fruit makes your attacks a little faster, a handful of blackberry potion fruits causes damage to anyone who attacks you, a handful of blueberry potion fruits is as hydrating as a bottle of water, a mayapple potion fruit lets you eat rotten or poisonous food, and so on. They generally have low durations and minor effects, as well as still spoiling (though after 10x the normal spoil duration), which is why modern potioncraft took over.
All recipes are autolearned, making them useful innawoods, but can also be found in a book (the autolearn level is higher than the level needed to make them).
Describe alternatives you've considered
Testing
WIP
Additional context
Yes, I got the idea from Dark Sun, the greatest D&D setting of all time.