Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amphibian Additions - Treefrogs #70535

Merged
merged 6 commits into from
Jan 2, 2024

Conversation

TheSaddestGoomba
Copy link
Contributor

Third times the charm

Summary

Content "Addition of three new, big-sized treefrog mutants. Minor tweaks to existing frog mutants."

Purpose of change

Describe the solution

Continuation of #67029 . Reimplementation of #70219 ...again.

Describe alternatives you've considered

Testing

Additional context

Third times the charm
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Mods: Tamable Wildlife labels Dec 30, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Termineitor244

@TheSaddestGoomba TheSaddestGoomba changed the title Everything but Speech.json Amphibian Additions - Treefrogs Dec 30, 2023
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Dec 30, 2023
Keeping speech.json to its own commit.
Less crowded this time.
Correct typos and add terms to dictionary
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • You've seen enough to gather that this is a frog with some very specialized camouflage. Its skin appears able to reactively change texture and color to match its surroundings. Like a morphing ghillie suit it can extend filaments to mimic individual leaves and blades of grass. It is keen enough to match the swaying of brush in the wind.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 31, 2023
One more dictionary entry
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 1, 2024
Add more generic sounds for wailing treefrogs
data/json/speech.json Outdated Show resolved Hide resolved
data/json/speech.json Outdated Show resolved Hide resolved
data/json/speech.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 1, 2024
Adjusting overcrowded speech entries
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 1, 2024
@Procyonae
Copy link
Contributor

You don't need to make a new PR when the tests fail, just push an empty commit (git commit -C HEAD --amend followed by a force push) or ask for a bump to the tests in the devcord. Also you should probably close #70219 (Or close this and use that PR)

@TheSaddestGoomba
Copy link
Contributor Author

You don't need to make a new PR when the tests fail, just push an empty commit (git commit -C HEAD --amend followed by a force push) or ask for a bump to the tests in the devcord. Also you should probably close #70219 (Or close this and use that PR)

Thank you, I'll close the first and post in the devcord for this PR since it's further along.

@Maleclypse Maleclypse merged commit a1b4bad into CleverRaven:master Jan 2, 2024
37 of 45 checks passed
@TheSaddestGoomba TheSaddestGoomba deleted the Treefrogs-v3 branch January 3, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Tamable Wildlife Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants