Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include error #73093

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix include error #73093

merged 1 commit into from
Apr 18, 2024

Conversation

anothersimulacrum
Copy link
Member

Summary

None

Purpose of change

Due to #72927, overmap.h is required in construction.h

Describe the solution

Include relevant headers.

Testing

Compiles.

@github-actions github-actions bot added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Apr 18, 2024
@RenechCDDA RenechCDDA mentioned this pull request Apr 18, 2024
Closed
@Brambor
Copy link
Contributor

Brambor commented Apr 18, 2024

I probably broke some fragile transitive include the #72927 relied on in #73040.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 18, 2024
@Maleclypse Maleclypse merged commit 5aaf8fd into CleverRaven:master Apr 18, 2024
28 checks passed
@anothersimulacrum anothersimulacrum deleted the include-overmap branch April 18, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anothersimulacrum @Brambor @Maleclypse