-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big Expansion to dialogue/messages for various categories #74360
Conversation
… notes, and dreams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line count is pretty much unreviewable*, and you don't need to remove the existing snippets before re-adding them.
Break it up into 500-1000 line chunks and submit it as multiple PRs, please.
*Both in the sense of "nobody will review 12K lines of JSON at once" and "my phone nopes out of Firefox when I open the diff"
It looks like your IDE changed the indentation from 2 spaces to 4, which is why there is such a huge diff. Before sending PR, you need format the files using a formatter, as described in the docs. Although the GitHub bot should have suggested a fix if the checks had not been stopped. |
yeah that's fair, ill try to just make a mod out of it then, sounds like a lot of hassle keep PR'ing and merging etc every 500 lines of dialogue. and takes away time from adding more content. Appreciate the comments tho. |
If you fix the whitespace stuff so it's mergeable period I don't mind reviewing it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still more to do
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Summary
Content "Massive expansion of dialogues and messages for various categories"
Purpose of change
To enrich the game experience by adding a diverse and extensive range of dialogues and messages. This includes health messages, schizophrenia dialogues, children's notes, survivor notes, and dreams, making the in-game interactions more immersive and varied.
Describe the solution
The solution involves adding multiple new entries to existing JSON files that contain dialogues and messages. These include:
health_msgs.json
: Expanded health status messages.schizophrenia.json
: Expanded dialogues and interactions related to schizophrenia.children_notes.json
: Added more notes from the perspective of children.dreams.json
: Added more diverse and twisted dreams.survivor_notes.json
: Expanded notes left by survivors.Describe alternatives you've considered
Testing
Loaded the game with the modified JSON files.
Ensured that the new messages and dialogues appear correctly in the game.
Verified that there are no syntax errors in the JSON files.
Checked that the game runs without any crashes or issues related to the new entries.
Additional context
The expansion aims to bring more depth and variety to the in-game text interactions