Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't apply parkour bonus when moving prone #77557

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

Night-Pryanik
Copy link
Contributor

Summary

Bugfixes "Don't apply parkour bonus when moving prone"

Purpose of change

Parkour is about walking and running, not about moving prone.

Describe the solution

Added check for being prone in Character::run_cost_effects.

Describe alternatives you've considered

Also add a check for moving crouched.

Testing

Changed move mode to prone. Moved over the bench in starting evac shelter. Checked that move cost is 750.
Get parkour expert proficiency. Moved over the same bench. Checked that move cost is still 750.

Additional context

None.

@Night-Pryanik Night-Pryanik added Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Character / Player Character / Player mechanics labels Nov 3, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 3, 2024
@Maleclypse Maleclypse merged commit 6b98896 into CleverRaven:master Nov 3, 2024
22 of 28 checks passed
@Night-Pryanik Night-Pryanik deleted the parkour branch November 4, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mechanics: Character / Player Character / Player mechanics Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants