Make creature overlay icons optional #78053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works but isn't easily cacheable so I think I'll drop the tileset field which'll have the benefit of making this alot neater too
github-actions
bot
added
[C++]
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Supersedes the sees_player_retro mod by allowing it to be changed in game without save file editing and across all tilesets
Describe the solution
Add a cached option to hide/show creature overlay "icons", specifically effects, sees_player and move_mode (not clothing, mutations etc)
Describe alternatives you've considered
Including an Auto option as the default that allows the selected tileset to pick instead (see first commit). I think this would've been nicer but it seemed like it would be awkward to cache and as far as I can tell this needs to be checked pretty often.
Splitting it into more nuanced options or going completely crazy and adding something akin to the autopickup manager for it so you could whitelist/blacklist individual effects etc
I'm not entirely happy with where the option is but idk where better to put it
Testing
Tested effects, sees_player and move_mode
Additional context
See #51910 (comment)
I'm saving removing sees_player_retro until I've merged its sprites into the base tileset and they're live