Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Allow attacking with CANNOT_MOVE flag #78310

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

b3brodie
Copy link
Contributor

@b3brodie b3brodie commented Dec 2, 2024

Summary

Bugfixes "Allow attacking with CANNOT_MOVE flag"

Purpose of change

Melee attacking should be doable with CANNOT_MOVE flag

Describe the solution

Since melee attacking is determined in the move method, the method cannot immediately return on presence of CANNOT_MOVE. Instead, move this check to after the melee attack portion.

Also, add a message warning players that they cannot move if they attempt movement to give feedback.

Describe alternatives you've considered

N/A

Testing

Added a test CANNOT_MOVE effect and confirmed that I could attack monsters next to me but still could not move.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Dec 2, 2024
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Dec 2, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 3, 2024
@Night-Pryanik Night-Pryanik merged commit eba9c9f into CleverRaven:master Dec 3, 2024
21 of 26 checks passed
@b3brodie b3brodie deleted the no_move branch December 3, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants