Fix typo in 'f_empty_spike' bash drops #78451
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
RenechCDDA
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Indeed, glass is the ID for a drinking glass, not glass shards. https://github.com/CleverRaven/Cataclysm-DDA/blob/cdda-experimental-2024-12-09-0933/data/json/items/generic/dining_kitchen.json#L472
LGTM
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Typo fixed for 'f_empty_spike' involving bash drops"
Purpose of Change
The typo in the
f_empty_spikedefinition caused incorrect bash drop behavior. This fix ensures the correct item,glass_shard, is dropped when the object is bashed.Describe the Solution
f_empty_spikeJSON entry to replace"glass"with"glass_shard"under thebashaction'sitemsfield.Testing
Additional Context
This fixes a minor issue with the object behavior, ensuring intended functionality.