Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate martial arts details window to imgui #78497

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented Dec 11, 2024

Summary

Interface "Migrate martial arts details window to imgui"

Purpose of change

Fixes #78431

Additional context

Wrap width calc is weird and needs to be addressed later, but it is not unique to this menu and more of a general problem of ImGui.

Screenshots:
image

image

image

image

image

image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Martial Arts Arts, Techniques, weapons and anything touching martial arts. <Bugfix> This is a fix for a bug (or closes open issue) Info / User Interface Game - player communication, menus, etc. labels Dec 11, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Qrox

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 11, 2024
@Night-Pryanik Night-Pryanik merged commit e10cfc1 into CleverRaven:master Dec 12, 2024
24 of 26 checks passed
@mqrause
Copy link
Contributor

mqrause commented Dec 12, 2024

Wrap width calc is weird and needs to be addressed later, but it is not unique to this menu and more of a general problem of ImGui.

Saw the PR a bit late. For automatic wrapping we have cataimgui::TextColoredParagraph now. Although it can't handle strings with line breaks currently, so you'd have to manually break them up if you have some of those.

@ZhilkinSerg ZhilkinSerg deleted the imgui-ma-details branch December 12, 2024 05:43
@ZhilkinSerg
Copy link
Contributor Author

Wrap width calc is weird and needs to be addressed later, but it is not unique to this menu and more of a general problem of ImGui.

Saw the PR a bit late. For automatic wrapping we have cataimgui::TextColoredParagraph now. Although it can't handle strings with line breaks currently, so you'd have to manually break them up if you have some of those.

Wrapping width calc there is much better, but there are some issues with paragraphs too - wrapped text apparently has different line spacing and it overlaps horizontal separator:
image

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Martial Arts Arts, Techniques, weapons and anything touching martial arts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fighting stances selection window stays on top of fighting details windows
3 participants