-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for overplotting a ocean/land mask with GeoMakie
#72
Conversation
If `attributes["units"]` is not a string, we cannot `uparse` it. This happens all the times we return a new `OutputVar` from one we have already processed. This commit adds a check that accounts for this case too. In this case, we just have to return the value.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
===========================================
- Coverage 96.35% 16.84% -79.51%
===========================================
Files 9 9
Lines 548 558 +10
===========================================
- Hits 528 94 -434
- Misses 20 464 +444 ☔ View full report in Codecov by Sentry. |
8a15bd8
to
036fc41
Compare
oooh that's cool!! |
"Applying the mask directly to the data is left for future work" we could make it a clear outlier and use
https://docs.makie.org/stable/reference/blocks/colorbar#colorbar |
036fc41
to
98a6fd9
Compare
My plan is to create an |
1df83f3
to
7d42770
Compare
This commit adds support for applying land/sea masks to GeoMakie plots. The masks are obtained directly from GeoMakie as a collection of polygons. For the ocean mask, we use bathymetry data at 0 elevation. Data is provided by `NaturalEarth.jl`. (I had to bump the minimum compat for GeoMakie to 0.7 because support `NaturalEarth.jl` was introduced in that release.) This new option is only aesthetics: it does change the underlying data (we simply overplot something else). This also means that the colorbar will include values under the mask. Applying the mask directly to the data is left for future work. Thanks @haakon-e for help with this feature.
7d42770
to
b2da5d8
Compare
This commit adds support for applying land/sea masks to GeoMakie plots. The masks are obtained directly from GeoMakie as a collection of polygons. For the ocean mask, we use bathymetry data at 0 elevation. Data is provided by
NaturalEarth.jl
. (I had to bump the minimum compat for GeoMakie to 0.7 because supportNaturalEarth.jl
was introduced in that release.)This new option is only aesthetics: it does change the underlying data (we simply overplot something else). This also means that the colorbar will include values under the mask. Applying the mask directly to the data is left for future work.
Thanks @haakon-e for help with this feature.