Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for overplotting a ocean/land mask with GeoMakie #72

Merged
merged 2 commits into from
Sep 1, 2024

Commits on Aug 31, 2024

  1. Account for case when units are already Unitful

    If `attributes["units"]` is not a string, we cannot `uparse` it. This happens
    all the times we return a new `OutputVar` from one we have already processed.
    
    This commit adds a check that accounts for this case too. In this case, we just
    have to return the value.
    Sbozzolo committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    b4ca516 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. Add option to mask ocean/land

    This commit adds support for applying land/sea masks to GeoMakie plots. The
    masks are obtained directly from GeoMakie as a collection of polygons. For the
    ocean mask, we use bathymetry data at 0 elevation. Data is provided by
    `NaturalEarth.jl`. (I had to bump the minimum compat for GeoMakie to 0.7 because
    support `NaturalEarth.jl` was introduced in that release.)
    
    This new option is only aesthetics: it does change the underlying data (we
    simply overplot something else). This also means that the colorbar will include
    values under the mask. Applying the mask directly to the data is left for future
    work.
    
    Thanks @haakon-e for help with this feature.
    Sbozzolo committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    b2da5d8 View commit details
    Browse the repository at this point in the history