Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LES experiments in ClimaAtmos #3059

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

LES experiments in ClimaAtmos #3059

wants to merge 20 commits into from

Conversation

akshaysridhar
Copy link
Member

SDI: #2999

This PR consolidates the key changes required to run ClimaAtmos in LES configurations. This links the changes in ClimaCore PR#1736 to updates in parameterized tendencies in ClimaAtmos.

@akshaysridhar akshaysridhar force-pushed the as/covar-deriv branch 2 times, most recently from d8fe8d3 to c4d57c3 Compare September 30, 2024 17:55
@akshaysridhar
Copy link
Member Author

akshaysridhar commented Oct 4, 2024

Preliminary 1M microphysics results (ClimaAtmos default ci-plot infrastructure used, with windowed time averages to avoid spin-up periods)
RICO:
summary_rico.pdf
BOMEX:
summary_bomex.pdf

@akshaysridhar akshaysridhar force-pushed the as/covar-deriv branch 2 times, most recently from c30389c to 6b3af24 Compare October 11, 2024 16:28
	modified:   src/parameterized_tendencies/les_sgs_models/smagorinsky_lilly.jl
	modified:   config/model_configs/les_rico_box.yml
	modified:   post_processing/ci_plots.jl
	modified:   config/model_configs/les_bomex_box.yml
Tested BOMEX (1M) + RICO (1M)
	modified:   src/parameterized_tendencies/les_sgs_models/smagorinsky_lilly.jl

Clean up before review
@akshaysridhar akshaysridhar marked this pull request as ready for review October 16, 2024 18:04
config/model_configs/les_bomex_box.yml Outdated Show resolved Hide resolved
config/model_configs/les_dycoms_box.yml Outdated Show resolved Hide resolved
config/model_configs/les_rico_box.yml Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this file be removed?

@haakon-e haakon-e requested a review from tapios November 4, 2024 21:17
z_stretch: false
x_elem: 45
config: "box"
hyperdiff: "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hyperdiff here seems to conflict with l. 9.

@@ -0,0 +1,175 @@
#####
##### Smagornsky Lilly Diffusion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
##### Smagornsky Lilly Diffusion
##### Smagorinsky Lilly Diffusion

FT = eltype(Y)
grav = CAP.grav(params)
thermo_params = CAP.thermodynamics_params(params)
Pr_t = FT(1 / 3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make turbulent Prandtl number a parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants