Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covariant derivatives on GPU #1736

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Covariant derivatives on GPU #1736

merged 1 commit into from
Aug 8, 2024

Conversation

akshaysridhar
Copy link
Member

@akshaysridhar akshaysridhar commented May 20, 2024

Extends the spectralelement operators on gpu to work identically compared with their cpu implementations. Towards Christoffel symbol computations and consistent tensor divergence calculations.

Removes two broken tags against cuda spectral element op tests following additions to ext/cuda/operators_spectral_element.jl.

Copy link
Member

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'm glad to see that the CPU/GPU are more unified with their results.

@akshaysridhar
Copy link
Member Author

This looks great! I'm glad to see that the CPU/GPU are more unified with their results.

Thanks! I'll rebase + format and merge shortly.

Adds unit tests (known trig solutions) for both cpu and gpu devices
which compare parent array outcomes
	modified:   ext/cuda/operators_sem_shmem.jl
	modified:   ext/cuda/operators_spectral_element.jl
	modified:   .buildkite/pipeline.yml
	modified:   test/runtests.jl

Relaxes test_broken on extruded CUDA operator tests (2 instances)
Add 2 additional operator tests
	modified:   test/Operators/hybrid/extruded_3dbox_cuda.jl
	modified:   test/Operators/hybrid/extruded_sphere_cuda.jl

Skip bounds check
	modified:   ext/cuda/operators_spectral_element.jl
@akshaysridhar akshaysridhar merged commit b38c1fb into main Aug 8, 2024
17 of 19 checks passed
@akshaysridhar akshaysridhar deleted the as/covar-deriv branch August 8, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants