Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:ipv4 column append problem #101

Closed
wants to merge 2 commits into from
Closed

fix:ipv4 column append problem #101

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2021

#88 fix:ipv4 column append problem.author: BozaB.

@BozaB
Copy link

BozaB commented Sep 16, 2021

Hellozhuzhu, thank you! :)

@filimonov
Copy link
Collaborator

Great, can you also add the problematic ip to the test?

v4->Append("127.0.0.1");

@ghost
Copy link
Author

ghost commented Sep 18, 2021

Of course.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


BozaB seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign CLA and write some unit tests, simple/main.cpp is not built/run in CI/CD

@Enmk Enmk mentioned this pull request Feb 2, 2022
@Enmk Enmk closed this in #148 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants