Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ColumnIPv4::Append() #148

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Fixed ColumnIPv4::Append() #148

merged 2 commits into from
Feb 3, 2022

Conversation

Enmk
Copy link
Collaborator

@Enmk Enmk commented Feb 2, 2022

Added tests, simplified implementation + few extra minor touches

Closes: #101, #88

@Enmk
Fixed ColumnIPv4i::Append()
88b96a1 
Added tests, simplified implementation + few extra minor touches
@Enmk Enmk changed the title Fixed ColumnIPv4i::Append() Fixed ColumnIPv4::Append() Feb 3, 2022
filimonov
filimonov approved these changes Feb 3, 2022
View reviewed changes
Copy link
Collaborator

@filimonov filimonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

[out of PR scope]: column tests can be improved a bit by introducing real clickhouse roundtrips (to ensure the byte order and other similar things are seen the same way by clickhouse-cpp & clickhouse itself).

@Enmk
Copy link
Collaborator Author

Enmk commented Feb 3, 2022

We have a 'Client'-tests for that.

@Enmk Enmk merged commit 166b825 into ClickHouse:master Feb 3, 2022
@Enmk Enmk mentioned this pull request Feb 3, 2022
Closed
@Enmk Enmk deleted the ipv4_append_fix branch February 3, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filimonov filimonov filimonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enmk @filimonov