-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MSVC #131
Merged
Merged
Add support for MSVC #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filimonov
force-pushed
the
windows-gh-actions
branch
from
January 6, 2022 13:30
82ee31f
to
5b5f302
Compare
filimonov
force-pushed
the
windows-gh-actions
branch
2 times, most recently
from
January 6, 2022 20:31
851221a
to
6b82e5a
Compare
Failure on clang: https://bugs.llvm.org/show_bug.cgi?id=16404 (happens only with static linking), looks caused by |
filimonov
force-pushed
the
windows-gh-actions
branch
2 times, most recently
from
January 10, 2022 15:36
4d895a9
to
f94a907
Compare
filimonov
force-pushed
the
windows-gh-actions
branch
from
January 20, 2022 14:30
49ad6d4
to
afdb9d2
Compare
is a real issue? |
Just a broken test, fixed |
Enmk
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known issues: