Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MSVC #131

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Add support for MSVC #131

merged 3 commits into from
Feb 1, 2022

Conversation

filimonov
Copy link
Collaborator

@filimonov filimonov commented Jan 6, 2022

Known issues:

  • no support for secure connections (need to reimplement secure_socket with sspi.h and other windows thing). Maybe can work with openssl (not tested).
  • there are some warnings at compile time

@Enmk Enmk self-assigned this Jan 6, 2022
@filimonov filimonov force-pushed the windows-gh-actions branch 2 times, most recently from 851221a to 6b82e5a Compare January 6, 2022 20:31
@filimonov
Copy link
Collaborator Author

Failure on clang: https://bugs.llvm.org/show_bug.cgi?id=16404 (happens only with static linking), looks caused by __builtin_mul_overflow call

@filimonov filimonov changed the title Create windows_msvc.yml Add support for MSVC Jan 8, 2022
This was referenced Jan 10, 2022
@filimonov filimonov force-pushed the windows-gh-actions branch 2 times, most recently from 4d895a9 to f94a907 Compare January 10, 2022 15:36
@filimonov
Copy link
Collaborator Author

 D:\a\clickhouse-cpp\clickhouse-cpp\ut\columns_ut.cpp(461): error: Expected equality of these values:
  0xffffffffffffffffll
    Which is: -1
  col->At(1)
    Which is: 18446744073709551615

is a real issue?

@Enmk
Copy link
Collaborator

Enmk commented Feb 1, 2022

 D:\a\clickhouse-cpp\clickhouse-cpp\ut\columns_ut.cpp(461): error: Expected equality of these values:
  0xffffffffffffffffll
    Which is: -1
  col->At(1)
    Which is: 18446744073709551615

is a real issue?

Just a broken test, fixed

Copy link
Collaborator

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enmk Enmk merged commit e251d21 into master Feb 1, 2022
@Enmk Enmk deleted the windows-gh-actions branch February 1, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add github actions for windows / MSVC build 'Failed to connect' exception using MSVC
2 participants