Update readme to show how to build and run hello world #144
Conversation
|
cnmade seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| @@ -22,6 +22,19 @@ C++ client for [ClickHouse](https://clickhouse.com/). | |||
| * Int128 | |||
| * UUID | |||
|
|
|||
| ## Requirement | |||
|
|
|||
| You need gcc cmake libabsl-dev to build this project. | |||
There was a problem hiding this comment.
- Should work without
libabsl-dev - gcc version 7 at least (clang >= 6 also supperted, after Add support for MSVC #131 MSVC should work also).
There was a problem hiding this comment.
To build with openssl libssl-dev is also needed.
There was a problem hiding this comment.
There was a problem hiding this comment.
Hello world does not need https i think. or am i wrong?
I just finish running the hello world for me ,so it's time to share how to run example code , may help who want to play .
There was a problem hiding this comment.
Hello world does not need https i think
that readme is for the clickhouse-cpp, why not make it clear for all the cases?
| GenericExample(client); | ||
| } | ||
|
|
||
| int main() { |
There was a problem hiding this comment.
There was a problem hiding this comment.
the simple directory source code not that simple, you can see so many code blocks.
Shall we start from very basic hello world example?
There was a problem hiding this comment.
OK for me. Just want to understand your motivation.
|
If this is not ok for any inconvence, i will close this pull request. |
ghost
closed this
|
It's almost ok. Your emotional reaction is not entirely clear. My comments were not correct / seemed rude? Comments/minor remarks are a natural element of code reviews. If you trying to make things better why do you stop half-road? |
|
@filimonov I am think is it my pull request too lower level, did really other people need it ? It's not about your comment/review. |
Add new basic hello world example.
Update readme to show how to build and run with the basic example
Fixed normal missing