use absl for int128 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@filimonov are you going to finish this? |
|
No :) I've just make a backport from artpaul repo to expose it here / to sync the projects. Have no idea what is broken and how to fix, and i know the code around very badly, feel free to pick it if you want. I guess some tiny efforts are needed to make it work. |
Closed
Added tests: * Basic cases for Int128 numeric columns * Parsing Decimal128 values from string (basic and with overflow) Known limitations: * Overflow checks are broken for std::numeric_limits<Int128>::min() when there is no __int128.
Tests for ItemView contructor
Fragile implementation of ItemView::ValidateData And several other minor issues.
Fixes #66 to allow using absl::int128 as Int128
|
Does absl int128 has some benefits over simply gnu++17? |
|
I am a bit concerned about potential ODR problems if someone uses both absl and clickhouse-cpp in their projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
artpaul/clickhouse-cpp#119
See
https://github.com/artpaul/clickhouse-cpp/issues/113
https://github.com/artpaul/clickhouse-cpp/issues/116