Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix enum parse logic when its last index is zero #1487

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

lobachpavel
Copy link
Contributor

Summary

Fix invalid Enum error when enum goes from negative indexes to zero, ex: Enum8('a'=-1, 'b'=0)

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2025

CLA assistant check
All committers have signed the CLA.

@jkaflik
Copy link
Contributor

jkaflik commented Feb 3, 2025

@lobachpavel thanks for your contribution. Please take a look on CLA agreement before we can merge.

@lobachpavel
Copy link
Contributor Author

@jkaflik

thank you for fast review!
done with CLA

is it possible to get this released this week?

@jkaflik
Copy link
Contributor

jkaflik commented Feb 3, 2025

I am not maintaining this library currently. @SpencerTorres FYI

@SpencerTorres SpencerTorres merged commit 9ae8c68 into ClickHouse:main Feb 3, 2025
12 checks passed
@SpencerTorres
Copy link
Member

@lobachpavel released in v2.30.3, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants