Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix enum parse logic when its last index is zero #1487

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix enum parse logic when its last index is zero #1487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/column/enum.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func extractEnumNamedValues(chType Type) (typ string, values []string, indexes [
}

// Enum type must have at least one value
if valueIndex == 0 {
if len(indexes) == 0 {
return
}

Expand Down
9 changes: 9 additions & 0 deletions lib/column/enum_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,15 @@ func TestExtractEnumNamedValues(t *testing.T) {
2: "",
},
},
{
name: "Enum8 from negative to zero keys",
chType: "Enum8('a'=-1, 'b'=0)",
expectedType: "Enum8",
expectedValues: map[int]string{
-1: "a",
0: "b",
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down
Loading