Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: VCF compression #1060

Merged
merged 6 commits into from
Feb 3, 2023
Merged

fix: VCF compression #1060

merged 6 commits into from
Feb 3, 2023

Conversation

khurrammaqbool
Copy link
Collaborator

This PR:

Fixed: Compression of SNV research and clinical VCF files.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@khurrammaqbool khurrammaqbool self-assigned this Jan 18, 2023
@khurrammaqbool khurrammaqbool requested a review from a team January 18, 2023 13:25
@khurrammaqbool khurrammaqbool linked an issue Jan 18, 2023 that may be closed by this pull request
[ Failed Analysis ] 4 WES cases fail on bcftools_filter_vardict_clinical_tumor_only and bcftools_filter_vardict_research_tumor_only #1056
Closed
@codecov
Copy link

codecov bot commented Jan 18, 2023 •
edited
Loading

Codecov Report

Base: 99.25% // Head: 99.25% // No change to project coverage 👍

Coverage data is based on head (26ec7a5) compared to base (d7edf47).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1060   +/-   ##
========================================
  Coverage    99.25%   99.25%           
========================================
  Files           29       29           
  Lines         1755     1755           
========================================
  Hits          1742     1742           
  Misses          13       13
Flag Coverage Δ
unittests 99.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ivadym
Copy link
Contributor

ivadym commented Feb 2, 2023 •
edited
Loading

We have 3 PRs with overlapping changes (#1060, #1081 and #1083). Either I would make only one PR or rebase the others to make it clear what has been done in each of them.

ivadym
ivadym approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🥇

CHANGELOG.rst Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khurrammaqbool khurrammaqbool merged commit fca0fac into develop Feb 3, 2023
@khurrammaqbool khurrammaqbool deleted the fix/vcf_compression branch February 3, 2023 10:29
@ivadym ivadym mentioned this pull request Feb 6, 2023
Merged
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivadym ivadym ivadym approved these changes

Assignees

@khurrammaqbool khurrammaqbool

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@khurrammaqbool @ivadym