Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cnvpytor cluster resources #1083

Merged
merged 6 commits into from
Feb 3, 2023

Conversation

khurrammaqbool
Copy link
Collaborator

This PR:

Added: Cluster resource allocation for CNVpytor.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@khurrammaqbool khurrammaqbool requested a review from a team February 1, 2023 13:33
@khurrammaqbool khurrammaqbool self-assigned this Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 99.25% // Head: 99.25% // No change to project coverage 👍

Coverage data is based on head (2f7cdf6) compared to base (049d5a1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1083   +/-   ##
========================================
  Coverage    99.25%   99.25%           
========================================
  Files           29       29           
  Lines         1755     1755           
========================================
  Hits          1742     1742           
  Misses          13       13           
Flag Coverage Δ
unittests 99.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@khurrammaqbool khurrammaqbool changed the title add: cnvpytor cluster resources fix: cnvpytor cluster resources Feb 1, 2023
@ivadym ivadym mentioned this pull request Feb 2, 2023
3 tasks
Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CHANGELOG.rst Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khurrammaqbool khurrammaqbool merged commit 117370b into develop Feb 3, 2023
@khurrammaqbool khurrammaqbool deleted the fix/cnvpytor_cluster_resources branch February 3, 2023 15:54
@ivadym ivadym mentioned this pull request Feb 6, 2023
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants