Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no more pytest generated files in my directory #1093

Merged
merged 5 commits into from
Feb 20, 2023
Merged

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Feb 13, 2023

This PR:

Removed:

  • Pytest file saved in balsamic directory

Review and tests:

  • Tests pass

Screenshot 2023-02-13 at 17 48 42

  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym marked this pull request as ready for review February 13, 2023 16:49
@ivadym ivadym requested a review from a team February 13, 2023 16:49
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 99.25% // Head: 99.25% // No change to project coverage 👍

Coverage data is based on head (b5307c8) compared to base (d5ce218).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1093   +/-   ##
========================================
  Coverage    99.25%   99.25%           
========================================
  Files           29       29           
  Lines         1755     1755           
========================================
  Hits          1742     1742           
  Misses          13       13           
Flag Coverage Δ
unittests 99.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@fevac fevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 🌟

tests/commands/plugins/conftest.py Outdated Show resolved Hide resolved
ivadym and others added 2 commits February 15, 2023 09:11
Co-authored-by: Eva C <29628428+fevac@users.noreply.github.com>
@ivadym ivadym requested a review from fevac February 15, 2023 08:21
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivadym ivadym merged commit 5d627dd into develop Feb 20, 2023
@ivadym ivadym deleted the fix-pytest-file branch February 20, 2023 12:25
@ivadym ivadym mentioned this pull request Apr 27, 2023
14 tasks
ivadym added a commit that referenced this pull request May 10, 2023
### Added:
* PIP specific missing tools to config #1096
* Filtering script to remove normal variants from TIDDIT #1120
* Store TMB files in HK #1144

### Changed:
* Fixed all conda container dependencies #1096
* Changed --max_sv_size in VEP params to the size of chr1 for hg19 #1124
* Increased time-limit for sambamba_exon_depth and picard_markduplicates to 6 hours #1143
* Update cosmicdb to v97 #1147
* Updated read the docs with the changes relevant to mention #1153

### Fixed:
* Update cryptography version (39.0.1) due to security alert #1087
* Bump cryptography to v40.0.2 and gsutil to v5.23 #1154
* Pytest file saved in balsamic directory #1093
* Fix varcall_py3 container bcftools dependency error #1097
* AscatNgs container #1155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants