Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/save a JSON file of summarised QC metrics #717

Closed
wants to merge 1 commit into from
Closed

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Aug 24, 2021

This PR:

Creates a QC pydantic model and dumps the summarised metrics into a JSON file.

Added:

  • Pydantic models that shape the QC metrics JSON generation.
  • qc_metrics_summary.json is saved in the analysis output directory.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivadym ivadym linked an issue Aug 24, 2021 that may be closed by this pull request
7 tasks
@ivadym ivadym marked this pull request as draft August 25, 2021 11:23
@hassanfa hassanfa changed the base branch from develop to master August 26, 2021 09:24
@hassanfa hassanfa changed the base branch from master to develop August 26, 2021 09:26
@hassanfa hassanfa changed the base branch from develop to develop_v2 August 26, 2021 10:27
@ivadym
Copy link
Contributor Author

ivadym commented Aug 26, 2021

#723 replaces this PR.

@ivadym ivadym closed this Aug 26, 2021
@ivadym ivadym deleted the feat/QC branch August 26, 2021 15:44
@ivadym ivadym removed a link to an issue Aug 27, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant