Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for nested virtualization #159

Merged
merged 1 commit into from
Oct 19, 2024
Merged

add support for nested virtualization #159

merged 1 commit into from
Oct 19, 2024

Conversation

abiosoft
Copy link
Contributor

@abiosoft abiosoft commented Aug 5, 2024 •
edited
Loading

Which issue(s) this PR fixes:

This PR adds support for nested virtualization, added in macOS 15 for m3 devices.

Additional documentation

Sample usage

platformConfig, err := vz.NewGenericPlatformConfiguration(vz.WithGenericMachineIdentifier(machineIdentifier))
if err != nil {
	return err
}

// nested virt
platformConfig.SetNestedVirtualizationEnabled(true)

@abiosoft abiosoft mentioned this pull request Aug 5, 2024
Merged
@AkihiroSuda
Copy link
Collaborator

@Code-Hex Could you take a look? 🙏

@AkihiroSuda
Copy link
Collaborator

ping @Code-Hex 🙇‍♂️

@hallyn
Copy link

hallyn commented Sep 6, 2024

This would be terrific :)

@abiosoft
Copy link
Contributor Author

abiosoft commented Sep 7, 2024

Instructions for those willing to test this with Lima can be found here lima-vm/lima#2530 (comment).

cfergeau
cfergeau reviewed Sep 17, 2024
View reviewed changes
virtualization_15.m Outdated Show resolved Hide resolved
cfergeau
cfergeau reviewed Sep 19, 2024
View reviewed changes
virtualization_15.m Outdated Show resolved Hide resolved
@abiosoft abiosoft force-pushed the enable-nested-virtualization branch 4 times, most recently from 77c5a98 to 8d63c17 Compare September 21, 2024 13:30
@abiosoft
Copy link
Contributor Author

I think all comments have been addressed.

Ping @Code-Hex 🥺

@cfergeau
Copy link
Contributor

I checked the latest version of the code, looks good to me!

@abiosoft
add support for nested virtualization
900e8e6 
Signed-off-by: Abiola Ibrahim <git@abiosoft.com>
@abiosoft abiosoft force-pushed the enable-nested-virtualization branch from 8d63c17 to 900e8e6 Compare October 4, 2024 11:54
@AkihiroSuda
Copy link
Collaborator

Merged in https://github.com/lima-vm/vz fork.
lima-vm@2a22b5e

@Code-Hex
Copy link
Owner

Code-Hex commented Oct 19, 2024 •
edited
Loading

@abiosoft I'm sorry delay response. I will check and merge this one 🙏
(Because I took the CCNA exam, Passed)

@Code-Hex
Copy link
Owner

wow this is good news to me

Code-Hex
Code-Hex approved these changes Oct 19, 2024
View reviewed changes
Copy link
Owner

@Code-Hex Code-Hex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Code-Hex Code-Hex merged commit d1fe5bd into Code-Hex:main Oct 19, 2024
2 of 7 checks passed
@abiosoft
Copy link
Contributor Author

abiosoft commented Oct 19, 2024 •
edited
Loading

At last! Thanks @Code-Hex.

(Because I took the CCNA exam, Passed)

And congratulations on your successful exam 🎉 .

@Code-Hex
Copy link
Owner

@abiosoft Thank you so much 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asauber asauber asauber left review comments

@cfergeau cfergeau cfergeau left review comments

@Code-Hex Code-Hex Code-Hex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abiosoft @AkihiroSuda @hallyn @cfergeau @Code-Hex @asauber