-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vz: add support for nested virtualization #2530
Conversation
1fd7d72
to
b946be0
Compare
b946be0
to
25bd2b7
Compare
Testing Instructions
For those willing to try this out, these are the steps. 1. Clone the sourceClone my fork of Lima and checkout
2. Build LimaFrom the root directory of Lima, perform a build. PS: You might need to unlink Brew version if previously installed with Brew.
3. Start Lima with nested virtualization enabledUse VZ driver and enabled nested virtualization. The vmType: vz
nestedVirtualization: true 4. Validate nested virtualization in Lima VMEnter the Lima VM with
If the VM is running Ubuntu, you can install
|
25bd2b7
to
bc39aed
Compare
|
||
if macOSProductVersion.LessThan(*semver.New("15.0.0")) { | ||
return fmt.Errorf("nested virtualization requires macOS 15 or newer") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be little nicer to add a helper like isNestedVirtualiztionAvailable() with these checks. This can also be implemented for linux, so it can be a common interface for all platforms.
I was able to create a Lima VM with KVM support with your testing instructions.
Very cool. Thank you for working on this. |
CI is failing https://github.com/lima-vm/lima/actions/runs/10903645853/job/30258186834?pr=2530
|
Yes, that is because the upstream PR is not yet merged and that is why I made it a draft PR. |
b5f9998
to
eb784b8
Compare
eb784b8
to
ddefc80
Compare
Code-Hex/vz#159 remains still unreviewed, maybe the repo should be forked? |
|
c574b0b
to
d0a8131
Compare
Signed-off-by: Abiola Ibrahim <git@abiosoft.com>
d0a8131
to
10a60fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
The failing test does not appear related to the code change and it appears to run Lima successfully https://github.com/lima-vm/lima/actions/runs/11231643603/job/31221517661?pr=2530#step:10:1133. 😕 |
This unfortunately happens all the time, and we are retriggering failed test many times each day. 😞 |
CI is green on the master, but this PR seems failing 4 times. Maybe the failure is caused by another recent change in vz? |
CI is now green, let's merge it |
This PR adds support for nested virtualization for the VZ driver via the
nestedVirtualization
yaml config.It is dependent on upstream PR Code-Hex/vz#159 getting merged.VZ has been forked lima-vm/vz#1.Nested virtualization is currently limited to m3 devices running macOS 15 or newer.