Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

add support for nested virtualization #1

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

abiosoft
Copy link

@abiosoft abiosoft commented Oct 4, 2024

Which issue(s) this PR fixes:

This PR adds support for nested virtualization, added in macOS 15 for m3 devices.

Additional documentation

Sample usage

platformConfig, err := vz.NewGenericPlatformConfiguration(vz.WithGenericMachineIdentifier(machineIdentifier))
if err != nil {
	return err
}

// nested virt
platformConfig.SetNestedVirtualizationEnabled(true)

@AkihiroSuda
Copy link
Member

CI not running?

@abiosoft
Copy link
Author

abiosoft commented Oct 4, 2024

CI not running?

I have no idea why.

@AkihiroSuda AkihiroSuda closed this Oct 4, 2024
@AkihiroSuda AkihiroSuda reopened this Oct 4, 2024
@AkihiroSuda
Copy link
Member

Format check is failing

Signed-off-by: Abiola Ibrahim <git@abiosoft.com>
@abiosoft abiosoft force-pushed the enable-nested-virtualization branch from 8d63c17 to 900e8e6 Compare October 4, 2024 11:54
@abiosoft
Copy link
Author

abiosoft commented Oct 4, 2024

Format check is failing

I've figured how to resolve it.
Can you kindly enable the workflow again? @AkihiroSuda.

@abiosoft
Copy link
Author

abiosoft commented Oct 4, 2024

FYI I have been having same issue of builds terminating abruptly (on other projects) with GIthub actions for some days now.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, CI is failing, but let's merge this

@AkihiroSuda AkihiroSuda merged commit 2a22b5e into lima-vm:main Oct 8, 2024
2 of 8 checks passed
@AkihiroSuda AkihiroSuda added this to the v4.0.0 milestone Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants