Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ When file is opened or focused, jump to it in project navigator #184

Open
austincondiff opened this issue Mar 22, 2022 · 4 comments
Open

✨ When file is opened or focused, jump to it in project navigator #184

austincondiff opened this issue Mar 22, 2022 · 4 comments
Labels
enhancement New feature or request UI This is UI related

Comments

@austincondiff
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
When a tab is clicked, or a file is opened via the quick open overlay, jump to that file in the project navigator, even if it is layers deep in a nested file structure.
@austincondiff austincondiff added the enhancement New feature or request label Mar 22, 2022
@lukepistrol
Copy link
Member

lukepistrol commented Mar 23, 2022 •
edited
Loading

related #123 and #137

@austincondiff
Copy link
Collaborator Author

austincondiff commented Mar 25, 2022 •
edited
Loading

Partially fixed in #123.

@lukepistrol If the folder that the file the user has opened is in a directory that is collapsed in the project navigator, we need to recursively open directories until we can scroll to it in one motion (not opening one folder after the other).

@lukepistrol lukepistrol self-assigned this Mar 28, 2022
@lukepistrol lukepistrol added the UI This is UI related label Mar 29, 2022
@austincondiff austincondiff changed the title [FEAT] - When file is opened or focused, jump to it in project navigator ✨ When file is opened or focused, jump to it in project navigator Mar 31, 2022
@nanashili
Copy link
Contributor

Has this been @lukepistrol ?

@stale stale bot added the wontfix This will not be worked on label Jun 20, 2022
@CodeEditApp CodeEditApp deleted a comment from stale bot Jun 20, 2022
@stale stale bot removed the wontfix This will not be worked on label Jun 20, 2022
@austincondiff
Copy link
Collaborator Author

austincondiff commented Oct 5, 2022 •
edited
Loading

What is the status of this? It doesn't look like this is done yet. @lukepistrol it looks like this is assigned to you, were you still planning on tackling this?

@lukepistrol lukepistrol removed their assignment Oct 6, 2022
@lukepistrol lukepistrol moved this to Todo in CodeEdit Project Nov 23, 2022
@CodeEditApp CodeEditApp deleted a comment from Shafikpur Dec 5, 2022
xinix909 pushed a commit to xinix909/CodeTransfer that referenced this issue Sep 7, 2024
@thecoolwinter @austincondiff @0xWDG
Custom Text View (CodeEditApp#211)
40d8e88 
<!--- IMPORTANT: If this PR addresses multiple unrelated issues, it will
be closed until separated. -->

### Description

Replaces `STTextView` with a custom TextView implementation. Creates a
new `TextView` and `TextViewController` classes that manage rendering
text, handling text input, and keybinds. `TextViewController` replaces
the `STTextViewController` class, connecting existing TextFormation
classes, syntax highlighting, and other existing text view extensions.

### Related Issues

* closes CodeEditApp#208 
* closes #195 
* closes CodeEditApp#184 
* closes CodeEditApp#57 

### Checklist

TextView TODOs:
- [X] load text
- [X] render text
- [X] scroll
- [X] wrap text
- [X] resize
- [x] syntax highlighting
- [x] cursor
- [x] edit text
    - [x] isEditable
    - [x] Insert
    - [x] Delete
        - [x] Delete line
        - [x] Delete word
        - [x] Delete character
        - [x] Delete across lines
    - [x] Paste
- [x] [Marked
Text](https://developer.apple.com/library/archive/documentation/TextFonts/Conceptual/CocoaTextArchitecture/TextEditing/TextEditing.html#//apple_ref/doc/uid/TP40009459-CH3-SW26)
- [x] Line Numbers
- [x] Select text
    - [x] Copy
- [x] Multiple cursors
- [x] Keyboard navigation
    - [x] Arrow keys
    - [x] Command & control arrow keys
    - [ ] Page up and down
- [x] Tab widths & indents
- [x] Live parameter updating
- [x] Undo/redo
- [x] Sync system appearance
- [x] Highlight brackets
- [x] TextFormation integration
- [ ] ~MacOS Sonoma cursor~ Leaving for future PR. Will require rework
of cursor view system.
- [x] Update text from SwiftUI Binding (two-way binding)
- [x] Accessibility
- [x] Drag and Drop (bad, will need a rework but okay for now)

--
- [x] I read and understood the [contributing
guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md)
as well as the [code of
conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code

### Screenshots

`// TODO`

---------

Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
Co-authored-by: Wesley de Groot <email@wesleydegroot.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request UI This is UI related
Projects
CodeEdit Project
Status: 📋 Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@austincondiff @lukepistrol @nanashili