Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Find Navigator #208

Open
5 of 6 tasks
Tracked by #347
RayZhao1998 opened this issue Mar 23, 2022 · 4 comments
Open
5 of 6 tasks
Tracked by #347

✨ Find Navigator #208

RayZhao1998 opened this issue Mar 23, 2022 · 4 comments
Labels
enhancement New feature or request navigator UI This is UI related workspace

Comments

@RayZhao1998
Copy link
Collaborator

RayZhao1998 commented Mar 23, 2022 •
edited by austincondiff
Loading

A basic view and functionality of finding in workspace has been implemented with #125 . But there's a lot of work to do.
@RayZhao1998 RayZhao1998 added the enhancement New feature or request label Mar 23, 2022
@austincondiff austincondiff changed the title [FEAT] - Find/Replace in workspace ✨ Find/Replace in workspace Mar 31, 2022
@austincondiff austincondiff changed the title ✨ Find/Replace in workspace ✨ Find Navigator Mar 31, 2022
@austincondiff austincondiff mentioned this issue Mar 31, 2022
Open
6 tasks
@melodell melodell mentioned this issue Apr 19, 2022
Closed
5 tasks
@stale stale bot added wontfix This will not be worked on and removed wontfix This will not be worked on labels May 30, 2022
@KaiTheRedNinja
Copy link
Contributor

I've got a working version of ignore case search, but doing the rest will require major changes to SearchModeModel.swift

@CodeEditApp CodeEditApp deleted a comment from stale bot Jun 28, 2022
@austincondiff
Copy link
Collaborator

@KaiTheRedNinja if you feel comfortable proceeding, I'd say go for it. Or if you'd like to keep things simple for now and do it later, you can always submit a PR of what you have.

@KaiTheRedNinja
Copy link
Contributor

ykw im ambitious i'll try and change SearchModeModel and make things work. Just changing the structure of a class for ease of use and some string comparing shouldn't be as hard as what I've had to do for the project navigator.

@KaiTheRedNinja KaiTheRedNinja mentioned this issue Jun 29, 2022
Merged
7 tasks
@austincondiff austincondiff moved this from 🏁 Complete to 🏃‍♂️ In Progress in CodeEdit Project Feb 17, 2023
@austincondiff
Copy link
Collaborator

FYI, I've gone through and created issues for each mentioned item in the issue description.

xinix909 pushed a commit to xinix909/CodeTransfer that referenced this issue Sep 7, 2024
@thecoolwinter @austincondiff @0xWDG
Custom Text View (CodeEditApp#211)
40d8e88 
<!--- IMPORTANT: If this PR addresses multiple unrelated issues, it will
be closed until separated. -->

### Description

Replaces `STTextView` with a custom TextView implementation. Creates a
new `TextView` and `TextViewController` classes that manage rendering
text, handling text input, and keybinds. `TextViewController` replaces
the `STTextViewController` class, connecting existing TextFormation
classes, syntax highlighting, and other existing text view extensions.

### Related Issues

* closes CodeEditApp#208 
* closes #195 
* closes CodeEditApp#184 
* closes CodeEditApp#57 

### Checklist

TextView TODOs:
- [X] load text
- [X] render text
- [X] scroll
- [X] wrap text
- [X] resize
- [x] syntax highlighting
- [x] cursor
- [x] edit text
    - [x] isEditable
    - [x] Insert
    - [x] Delete
        - [x] Delete line
        - [x] Delete word
        - [x] Delete character
        - [x] Delete across lines
    - [x] Paste
- [x] [Marked
Text](https://developer.apple.com/library/archive/documentation/TextFonts/Conceptual/CocoaTextArchitecture/TextEditing/TextEditing.html#//apple_ref/doc/uid/TP40009459-CH3-SW26)
- [x] Line Numbers
- [x] Select text
    - [x] Copy
- [x] Multiple cursors
- [x] Keyboard navigation
    - [x] Arrow keys
    - [x] Command & control arrow keys
    - [ ] Page up and down
- [x] Tab widths & indents
- [x] Live parameter updating
- [x] Undo/redo
- [x] Sync system appearance
- [x] Highlight brackets
- [x] TextFormation integration
- [ ] ~MacOS Sonoma cursor~ Leaving for future PR. Will require rework
of cursor view system.
- [x] Update text from SwiftUI Binding (two-way binding)
- [x] Accessibility
- [x] Drag and Drop (bad, will need a rework but okay for now)

--
- [x] I read and understood the [contributing
guide](https://github.com/CodeEditApp/CodeEdit/blob/main/CONTRIBUTING.md)
as well as the [code of
conduct](https://github.com/CodeEditApp/CodeEdit/blob/main/CODE_OF_CONDUCT.md)
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code

### Screenshots

`// TODO`

---------

Co-authored-by: Austin Condiff <austin.condiff@gmail.com>
Co-authored-by: Wesley de Groot <email@wesleydegroot.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request navigator UI This is UI related workspace
Projects
CodeEdit Project
Status: 🏃‍♂️ In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@austincondiff @RayZhao1998 @KaiTheRedNinja