Find navigator improvements

[KaiTheRedNinja]

Description

What's been implemented:

• Ignore/match case (UI needs fixing)
• Regex
• Containing term
• Matching word
• Starting with word
• Ending with word

File specific changes:

• CodeEdit/Documents/WorkspaceDocument+Search.swift
  • Moved selectedMode from FindNavigatorModeSelector to here
  • Added ignoreCase boolean
  • Redid search function for clarity (replacing if lets with guard lets, etc to avoid too many ifs in ifs)
  • Added lineContainsSearchTerm to contain regex, containing term, matching/starting/ending word checks
• CodeEdit/NavigatorSidebar/FindNavigator/FindNavigator.swift
  • Added ignore case/matching case toggle UI (NEEDS FIXING)
• CodeEdit/NavigatorSidebar/FindNavigator/FindNavigatorModeSelector.swift
  • Added SearchState reference (the mode selector now edits this instead of its own local version
  • Changed selectedMode so that it updates the state on set
  • Removed unused getAllModes function (the children property can be used instead)

Related Issue

• ✨ Find Navigator #208

Checklist

• Fix Ignore/match case UI (currently looks a bit weird. Need help with this one.)
• Check implementations of searches
• I read and understood the contributing guide as well as the code of conduct
• My changes generate no new warnings
• My code builds and runs on my machine
• I documented my code
• Review requested

Screenshots

The broken UI (adding spacers doesn't help push the text to the right side): now fixed
old: fixed:

[0xWDG]

LGTM (not able to test the code ATM)

[thecoolwinter]

Running this I'm getting a crash Swift/UnsafeBufferPointer.swift:898: Fatal error when there's a ton of results (eg searching "hi" and returning a whole ton of files).
Along with the crash it's also giving me the error
the ID Optional("--") occurs multiple times within the collection, this will give undefined results! In a ForEach body.
I think it's just that the ID for each search result needs to be unique but right now it's using the value of the result's string.

[KaiTheRedNinja]

Running this I'm getting a crash Swift/UnsafeBufferPointer.swift:898: Fatal error when there's a ton of results (eg searching "hi" and returning a whole ton of files). Along with the crash it's also giving me the error the ID Optional("--") occurs multiple times within the collection, this will give undefined results! In a ForEach body. I think it's just that the ID for each search result needs to be unique but right now it's using the value of the result's string.

Turns out that this was an error in one of the files that I hadn't even touched in my PR (CodeEdit/NavigatorSidebar/FindNavigator/FindNavigatorResultFileItem.swift), and somehow the changes that I made allowed those errors to pop up. Making the ID reliant on the whole class instead of just the display name solved the issue.

[thecoolwinter]

LGTM