adding focus and keyboard accessibility to the cookie consent buttons #945
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| color="tertiary" | ||
| label="Decline" | ||
| startContent={<X />} | ||
| onPress={() => onClickButton(false)} | ||
| /> | ||
|
|
||
| <ThemeButton | ||
| tabIndex={2} |
There was a problem hiding this comment.
This is one of those exceptions to the rule that I think is okay.
Although I have seen it said somewhere on the A11y Slack channel that by now screenreader users just expect that the cookie banner will be on the bottom and they will TAB backwards to get to it.
| @@ -3,12 +3,15 @@ | |||
| import { ThemeButton } from "./ThemeButton"; | |||
| import { Check, X } from "@phosphor-icons/react"; | |||
| import { useCookieContext } from "@/context/CookieContext"; | |||
| import { useEffect, useState } from "react"; | |||
| import { useEffect, useState, useRef } from "react"; | |||
There was a problem hiding this comment.
It looks like you have a couple of small conflicts that need to be resolved with main.
|
Hi @Amberroseweeks I've changed the PR target branch from |
Deploy Staging to Main branch
|
Hi @Amberroseweeks, looks like the latest Vercel deployment to its preview env has failed. Can you run lint in your local env and see if any lint error appears? Thanks! |
Deploy Staging to Main branch
Weekly PR from Staging to Main
|
This PR has been marked as stale because it has been open for 7 days with no activity. |
|
Hey @Amberroseweeks Just checking in on this PR! Can you please check for failing tests or lint errors locally? |
Weekly PR from Staging to Main
…ps://github.com/Amberroseweeks/vacant-lots-proj into amberroseweeks-859-cookie-consent-keyboard-a11y
I think I have successfully fixed the issue, I pulled changes from main the combines my changes. |
Note: I added positive tab values for the Accept and Decline buttons. This feels a little wrong, I am not sure if this is best practice, but it did seem to work in allowing those items to receive focus first.
This closes issue #859