-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding focus and keyboard accessibility to the cookie consent buttons #945
Merged
bacitracin
merged 11 commits into
CodeForPhilly:staging
from
Amberroseweeks:amberroseweeks-859-cookie-consent-keyboard-a11y
Nov 3, 2024
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fed8c2e
adding focus and keyboard accessibility to the cookie consent buttons
Amberroseweeks df3fdbf
Merge branch 'staging' into amberroseweeks-859-cookie-consent-keyboar…
Amberroseweeks ecdf029
Merge pull request #959 from CodeForPhilly/staging
CodeWritingCow 1832ac0
Merge pull request #961 from CodeForPhilly/staging
nlebovits 231e155
Merge pull request #963 from CodeForPhilly/staging
nlebovits dd59156
Merge pull request #964 from CodeForPhilly/staging
CodeWritingCow 293e3e5
Merge pull request #967 from CodeForPhilly/staging
nlebovits 0da3b21
Merge pull request #969 from CodeForPhilly/staging
nlebovits f313207
Merge pull request #975 from CodeForPhilly/staging
CodeWritingCow bf5c0e2
Merge branch 'main' of https://github.com/CodeForPhilly/vacant-lots-p…
Amberroseweeks b6c1d19
Merge branch 'amberroseweeks-859-cookie-consent-keyboard-a11y' of htt…
Amberroseweeks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of those exceptions to the rule that I think is okay.
Although I have seen it said somewhere on the A11y Slack channel that by now screenreader users just expect that the cookie banner will be on the bottom and they will TAB backwards to get to it.