Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable global_namespace_import rule #1

Merged
merged 3 commits into from
Oct 31, 2021

Conversation

kenjis
Copy link
Contributor

@kenjis kenjis commented Oct 29, 2021

@paulbalandan
Copy link
Collaborator

@kenjis please rebase

@kenjis kenjis force-pushed the global_namespace_import-true branch from 1eb04d5 to ab76272 Compare October 29, 2021 22:53
@kenjis
Copy link
Contributor Author

kenjis commented Oct 29, 2021

Rebased.

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Excited to have it trickle down to projects!

src/CodeIgniter4.php Outdated Show resolved Hide resolved
src/CodeIgniter4.php Outdated Show resolved Hide resolved
@paulbalandan paulbalandan changed the title global_namespace_import to true Enable global_namespace_import rule Oct 31, 2021
@paulbalandan paulbalandan merged commit 7557e0b into CodeIgniter:develop Oct 31, 2021
@paulbalandan
Copy link
Collaborator

thank you, @kenjis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants