Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: global_namespace_import true #5250

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 28, 2021

Description

--- a/src/CodeIgniter4.php
+++ b/src/CodeIgniter4.php
@@ -171,7 +171,7 @@ final class CodeIgniter4 extends AbstractRuleset
                 'fix_inline'     => true,
                 'replacements'   => ['inheritDocs' => 'inheritDoc'],
             ],
-            'global_namespace_import'     => false,
+            'global_namespace_import'     => true,
             'group_import'                => false,
             'header_comment'              => false, // false by default
             'heredoc_indentation'         => ['indentation' => 'start_plus_one'],

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis merged commit 9a39199 into codeigniter4:develop Oct 29, 2021
@kenjis kenjis deleted the global_namespace_import-true branch October 29, 2021 04:10
paulbalandan pushed a commit to CodeIgniter/coding-standard that referenced this pull request Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants