Rework DOM to better separate elements from events #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-itd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-sdc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-curriculum canceled.
|
✅ Deploy Preview for cyf-tracks ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-launch ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Fixes #332 This way, we: * Fully handle accessing and setting DOM element properties in one chunk, then introduce events, rather than muddling the two together. * Identify that there are two common actions to do, and talk through identifying and addressing this. * Pull out the "what is the character limit" to be defined by the HTML attribute, rather than duplicated in the script. * Practice breaking down the "remaining characters" problem into sub-problems. * Generally solve things more incrementally. * Explicitly call out "do a clean-up refactoring" at the end. Also some misc copy edits.
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
Co-authored-by: Sally McGrath <sally@codeyourfuture.io>
illicitonion
force-pushed
the
dwh-dg-sprint3-rework
branch
from
ab58d3e
to
bb57bdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes #332
This way, we:
Also some misc copy edits.
Common Content?
Yes - changes, reorders, and adds blocks to much of JS2.
Org Content?
Data Groups Sprint 3
Checklist