Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error 404 page #828

Closed
khareyash05 opened this issue Aug 8, 2021 · 6 comments · Fixed by #832
Closed

Error 404 page #828

khareyash05 opened this issue Aug 8, 2021 · 6 comments · Fixed by #832
Assignees
Labels
enhancement New feature or request

Comments

@khareyash05
Copy link
Contributor

There is no error 404 page for the same I would like to make one.

@moshfeu
Copy link
Member

moshfeu commented Aug 8, 2021

Right!
Go for it :)
Do you have a design in your mind? Maybe we can take the design from the portfolio site: e.g. https://codingcoach.io/not-found

@moshfeu moshfeu added the enhancement New feature or request label Aug 8, 2021
@khareyash05
Copy link
Contributor Author

I dont have one . thank you for the design

@khareyash05
Copy link
Contributor Author

@moshfeu Can I use bootstrap for the error page ?

@moshfeu
Copy link
Member

moshfeu commented Aug 10, 2021

Better not to because we don't use it elsewhere.
Can you manage it without?

@khareyash05
Copy link
Contributor Author

Ya I can manage Thanx

@khareyash05
Copy link
Contributor Author

khareyash05 commented Aug 12, 2021

@moshfeu how to solve this- The error page is displaying on the home screen and this is my code for route
<Route component={PageNotFound} />
and this is lazy component
const PageNotFound = React.lazy(() =>import(/* webpackChunkName: "ErrorPage" */ './PageNotFound'));

2021-08-12.08-01-01.online-video-cutter.com.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants