add error404 page #832
Merged
add error404 page #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
moshfeu
requested changes
Aug 12, 2021
There was a problem hiding this comment.
Way better :)
Can you use styled component rather than pure css like we do in the (almost) entire project?
Co-authored-by: Mosh Feu <moshfeu@gmail.com>
|
@moshfeu It will take some time as I will have to learn but i will do that |
|
No rush :) |
|
@moshfeu Used styled components. Have a look |
|
@moshfeu Have a look! |
moshfeu
approved these changes
Aug 16, 2021
|
@moshfeu is my PR ready to merge?? |
Basically yes. By unknown reason, some unrelated tests are failing. I'm re-running the tests maybe they flaky. |
|
The build keeps failing :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #828
Added error 404 page