Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 404 page #829

Closed
wants to merge 2 commits into from
Closed

add 404 page #829

wants to merge 2 commits into from

Conversation

khareyash05
Copy link
Contributor

@khareyash05 khareyash05 commented Aug 9, 2021

fix #828
Added the error 404 page @moshfeu

Copy link
Member

@moshfeu moshfeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for very much for your time and efforts ❤️
Please see my comments.

@@ -0,0 +1,131 @@
@import url("https://fonts.googleapis.com/css2?family=Poppins:wght@700&display=swap");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're styling with styledComponents rather than css files, can you do that (example)?

src/404.js Show resolved Hide resolved
src/404.css Show resolved Hide resolved
src/404.css Show resolved Hide resolved

const ErrorPage = () => {
return (
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's try to include Header to have the site header (logo, menu etc.)
  2. Let's try to stick the portfolio site's 404 with necessary changes in the content. It looks nice, informative and has important links.

Screen Shot 2021-08-10 at 11 57 25

src/404.js Show resolved Hide resolved
src/index.tsx Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
Co-authored-by: Mosh Feu <moshfeu@gmail.com>
@khareyash05
Copy link
Contributor Author

@moshfeu Creating a new PR Thank you for your efforts

@khareyash05 khareyash05 deleted the error404 branch August 10, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 404 page
2 participants