🏗 Massive merge of upstream facebook create-react-app #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official documentation offers a simpler way of achieving route based code splitting.
…ebook#7839) * added check for typescript template and unsupported node version * addressed code review feedback regarding syntax and spelling mistakes
Update the initial project structure generated by create-react-app.
* Add header to checkValidServiceWorker (ts) * Add header to checkValidServiceWorker
…ok#6352) * Add additional information for postcss errors * Add additional information for postcss errors (simplify) * Remove chunkname from postCSS compile error * Remove line number from postCSS compile error
* Add Alex to lint documentation * Attempt to trigger GitHub Action * Configure Alex and update docs * More docs updates
* Add template support * Update templates version check * Update TypeScript template README
…book#7814) Rebased again now with smaller changes in this one which will make it easier to revert in case of eventual regressions.
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
* Added React logo in README.md * Added React logo in README file that makes looks nicer now. * Added CRA Logo in README.md that looks nicer * Replacing React Logo with CRA Logo instead Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> * Update README.md Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
- 🐛 use resolveApp for paths in config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 WIP
This is an attempt to bring our create-react-app back up to speed with the latest and greatest from Facebook.
I am not 100% confident yet that things are good to go, so I am going to continue to test but wanted to get this up in case someone else wanted to try it out or had any comments.
To test I've been using
npm linkto link the@zeal/react-scriptsand then using the zeal react generator to generate react apps.