Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent possible leakage from discord.Message objects in Streams #4731

Closed
Jackenmen opened this issue Jan 13, 2021 · 0 comments · Fixed by #4742
Closed

Prevent possible leakage from discord.Message objects in Streams #4731

Jackenmen opened this issue Jan 13, 2021 · 0 comments · Fixed by #4742
Assignees
@Jackenmen
Labels
Blocked By: Other PR Blocked by another PR. Category: Cogs - Streams This is related to the Streams cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Type: Optimisation Situations where too much time is necessary to complete the task.

Comments

@Jackenmen
Copy link
Member

Jackenmen commented Jan 13, 2021 •
edited
Loading

Currently, we're caching whole message objects for the messages made by Streams cog so that we can auto delete them. This is prone to leakage on gateway reconnection so we should instead cache only channel id and message id and use the partial message objects to delete alert messages.
Doing it like this is dependent on d.py 1.6 in Red, so for now this is blocked by #4728
@Jackenmen Jackenmen self-assigned this Jan 13, 2021
@github-actions github-actions bot added the Status: Needs Triage This has not been labeled or discussed for handling yet. label Jan 13, 2021
@Jackenmen Jackenmen added Category: Cogs - Streams This is related to the Streams cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Type: Optimisation Situations where too much time is necessary to complete the task. Blocked By: Other PR Blocked by another PR. and removed Status: Needs Triage This has not been labeled or discussed for handling yet. labels Jan 13, 2021
@Jackenmen Jackenmen mentioned this issue Jan 18, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jackenmen Jackenmen

Labels
Blocked By: Other PR Blocked by another PR. Category: Cogs - Streams This is related to the Streams cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Type: Optimisation Situations where too much time is necessary to complete the task.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use partial messages in Streams cog to avoid potential leakage Jackenmen/Red-DiscordBot
1 participant
@Jackenmen