Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update d.py to 1.6.0, aiohttp to 3.7.3, Red-Lavalink to 0.7.2 #4728

Merged
merged 4 commits into from
Feb 1, 2021
Merged

Update d.py to 1.6.0, aiohttp to 3.7.3, Red-Lavalink to 0.7.2 #4728

merged 4 commits into from
Feb 1, 2021

Conversation

Jackenmen
Copy link
Member

Type

  • Bugfix
  • Enhancement
  • New feature
  • Dependency update

Description of the changes

  • Update d.py to 1.6.0, aiohttp to 3.7.3, Red-Lavalink to 0.7.2 (the last one because of the dependency conflict with aiohttp 3.7+)
  • Remove suppression of deprecation warnings that are no longer relevant with the update of aiohttp
  • Change things that require changing after bumping d.py 1.6
    • in this update, it's only some max concurrency things in Command.prepare()
  • Remove two random AttributeError exception catching that doesn't make sense at least since d.py 1.1...

After this PR gets merged, #3529 should be updated appropriately.

@Jackenmen Jackenmen added Blocked By: Dependency Blocked by a package listed as a dependency. Type: Dependency Update Adding/updating/removing some of Red’s dependencies. labels Jan 13, 2021
@Jackenmen Jackenmen added this to the 3.4.6 milestone Jan 13, 2021
@github-actions github-actions bot added Category: Bot Core Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. Category: Core - Modlog This is related to the core Modlog API. labels Jan 13, 2021
@Jackenmen Jackenmen mentioned this pull request Jan 13, 2021
Closed
@Drapersniper
Copy link
Contributor

RLL 0.7.2 hasn't been release yet?

@Jackenmen
Copy link
Member Author

RLL 0.7.2 hasn't been release yet?

Nope, the current version is 0.7.1. I've only made the PR that requires us to make RLL 0.7.2 release 10 hours ago:
Cog-Creators/Red-Lavalink#87

@Jackenmen Jackenmen added Release Blocker This needs handling prior to the next non-hotfix release. and removed Blocked By: Dependency Blocked by a package listed as a dependency. labels Jan 17, 2021
@Jackenmen Jackenmen closed this Jan 17, 2021
@Jackenmen Jackenmen reopened this Jan 17, 2021
@Jackenmen
Copy link
Member Author

Closed&reopened because I am really annoyed by that one failing check.

@Jackenmen Jackenmen mentioned this pull request Jan 18, 2021
Merged
3 tasks
@Jackenmen Jackenmen added the Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. label Jan 20, 2021
@Jackenmen Jackenmen mentioned this pull request Jan 20, 2021
Closed
3 tasks
@aikaterna
Copy link
Member

Thanks for the input, folks that have been testing d.py 1.6 on your bots. I'm going to approve this based on your guys' approvals and after talking with folks about the RLL bump as well.

@Jackenmen Jackenmen merged commit 8139587 into Cog-Creators:V3/develop Feb 1, 2021
@Jackenmen Jackenmen deleted the V3/dpy_1.6 branch February 1, 2021 13:50
@Jackenmen Jackenmen mentioned this pull request Mar 6, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobloy bobloy bobloy requested changes

@aikaterna aikaterna aikaterna approved these changes

@Bakersbakebread Bakersbakebread Bakersbakebread approved these changes

@flaree flaree flaree approved these changes

@NeuroAssassin NeuroAssassin NeuroAssassin approved these changes

@PredaaA PredaaA PredaaA approved these changes

@rohitp30 rohitp30 rohitp30 approved these changes

@phenom4n4n phenom4n4n phenom4n4n approved these changes

@madebylydia madebylydia madebylydia approved these changes

@ltzmax ltzmax ltzmax approved these changes

@OofChair OofChair OofChair approved these changes

@Kreusada Kreusada Kreusada approved these changes

Assignees
No one assigned
Labels
Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. Category: Core - Modlog This is related to the core Modlog API. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Release Blocker This needs handling prior to the next non-hotfix release. Type: Dependency Update Adding/updating/removing some of Red’s dependencies.
Projects
None yet
Milestone
3.4.6
Development

Successfully merging this pull request may close these issues.