Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup]adds handling for messages cont. emojis/links #4483

Closed
wants to merge 28 commits into from
Closed

[Cleanup]adds handling for messages cont. emojis/links #4483

wants to merge 28 commits into from

Conversation

kablekompany
Copy link
Contributor

@kablekompany kablekompany commented Oct 12, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

[p]cleanup emoji
[p]cleanup links

each default to searching for 10 messages respectively

Blocked by #4728 ([p]cleanup stickers)

@kablekompany
Copy link
Contributor Author

Have made this change on my own red, and can confirm no false positives as of yet on link or emoji clearing (unicode emojis of course are not purged). Initially I had an alias with `cleanup text ":" to sort of target either but couldn't settle for one or the other, and it would always clean both. This has been tested in a moderation environment where chat speed is variable of 1-2msgs per second with enforced slowmode of 30s (so you can imagine the spam, ads, emoji overuse encountered).

Just wanted to validate positive test to date and provide operational stroke of proposed addition, regardless if there is intent or desire for use.

Thanks!

@Jackenmen Jackenmen added Category: Cogs - Cleanup This is related to the Cleanup cog. Type: Feature New feature or request. labels Oct 19, 2020
@Jackenmen Jackenmen added this to the Backlog milestone Oct 19, 2020
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a review, I just had two things I wanted to mention. Feel free to ignore this until actual review comes up.

redbot/cogs/cleanup/cleanup.py Outdated Show resolved Hide resolved
redbot/cogs/cleanup/cleanup.py Outdated Show resolved Hide resolved
@kablekompany
Copy link
Contributor Author

applied the noted changes (i think)
let me know if that diff is fucky (git is confusing for me at times 😓 )

@kablekompany
Copy link
Contributor Author

moved emoji regex to core and added unicode emoji regex extracting to core as well
Can revert if these properties are not sufficient for core otherwise.

making the unicode regex accessible could open up use cases in automod filters or further expanding cleanup functions.

@kablekompany kablekompany marked this pull request as draft October 30, 2020 07:21
@kablekompany
Copy link
Contributor Author

kablekompany commented Oct 30, 2020

successfully got the git blame back on track

@kablekompany kablekompany marked this pull request as ready for review October 30, 2020 07:37
* redbot/V3/develop:
  Automated Crowdin downstream (#4567)
  Fix leaderboard error in DMs for global banks (#4569)
* redbot/V3/develop:
  Fix `reason` variable shadowing in `[p]massban` (#4575)
  Automated Crowdin downstream (#4578)
* redbot/V3/develop:
  Bump versions of actions used by our workflows (#4586)
  [Docs] CogManagerUI user guide (#4152)
@kablekompany
Copy link
Contributor Author

Added support for cleanup stickers

Cause those were a fantastic idea and definitely not spammed :XtoDoubt:

@Jackenmen Jackenmen added the Blocked By: Other PR Blocked by another PR. label Jan 20, 2021
@Jackenmen Jackenmen assigned Jackenmen and unassigned Jackenmen Jan 20, 2021
@Jackenmen Jackenmen modified the milestones: 3.4.6, 3.4.7 Jan 20, 2021
@Jackenmen Jackenmen added the Status: Needs Discussion Needs more discussion. label Jan 20, 2021
@kablekompany
Copy link
Contributor Author

Will discontinue pulling in base unless otherwise expressed this is a potential wanted merge. Just to save us all some email notifs 😅

will rectify a final updated upstream when/if that review is requested. Cheers!

@github-actions github-actions bot added Category: Cogs - Mod This is related to the Mod cog. Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` labels Feb 18, 2021
@github-actions github-actions bot removed the Category: Cogs - Mod This is related to the Mod cog. label Feb 18, 2021
@Jackenmen Jackenmen removed this from the 3.4.11 milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked By: Other PR Blocked by another PR. Category: Cogs - Cleanup This is related to the Cleanup cog. Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Status: Needs Discussion Needs more discussion. Type: Feature New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants