-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup]adds handling for messages cont. emojis/links #4483
Conversation
Have made this change on my own red, and can confirm no false positives as of yet on link or emoji clearing (unicode emojis of course are not purged). Initially I had an alias with `cleanup text ":" to sort of target either but couldn't settle for one or the other, and it would always clean both. This has been tested in a moderation environment where chat speed is variable of 1-2msgs per second with enforced slowmode of 30s (so you can imagine the spam, ads, emoji overuse encountered). Just wanted to validate positive test to date and provide operational stroke of proposed addition, regardless if there is intent or desire for use. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a review, I just had two things I wanted to mention. Feel free to ignore this until actual review comes up.
applied the noted changes (i think) |
moved emoji regex to core and added unicode emoji regex extracting to core as well making the unicode regex accessible could open up use cases in automod filters or further expanding cleanup functions. |
successfully got the git blame back on track |
Added support for cleanup stickers Cause those were a fantastic idea and definitely not spammed :XtoDoubt: |
Will discontinue pulling in base unless otherwise expressed this is a potential wanted merge. Just to save us all some email notifs 😅 will rectify a final updated upstream when/if that review is requested. Cheers! |
Type
Description of the changes
[p]cleanup emoji
[p]cleanup links
each default to searching for 10 messages respectively
Blocked by #4728 (
[p]cleanup stickers
)