Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use partial messages in Streams cog to avoid potential leakage #4742

Merged
merged 8 commits into from
Apr 5, 2021
Merged

Use partial messages in Streams cog to avoid potential leakage #4742

merged 8 commits into from
Apr 5, 2021

Conversation

Jackenmen
Copy link
Member

@Jackenmen Jackenmen commented Jan 18, 2021 •
edited
Loading

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes #4731

@Jackenmen Jackenmen added Blocked By: Other PR Blocked by another PR. Type: Fix labels Jan 18, 2021
@Jackenmen Jackenmen added this to the 3.4.6 milestone Jan 18, 2021
@github-actions github-actions bot added the Category: Cogs - Streams This is related to the Streams cog. label Jan 18, 2021
@Jackenmen Jackenmen added Type: Optimisation Situations where too much time is necessary to complete the task. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. labels Jan 20, 2021
@Jackenmen Jackenmen removed the Blocked By: Other PR Blocked by another PR. label Feb 1, 2021
@Jackenmen Jackenmen force-pushed the V3/use_partial_messages_in_streams branch from 7376260 to 655f41d Compare February 1, 2021 13:55
@Jackenmen Jackenmen modified the milestones: 3.4.6, 3.4.7 Feb 15, 2021
@Jackenmen Jackenmen modified the milestones: 3.4.9, 3.4.8 Apr 3, 2021
@Jackenmen Jackenmen changed the title Use partial messages in Streams cog to avoid leakage Use partial messages in Streams cog to avoid potential leakage Apr 3, 2021
TrustyJAID
TrustyJAID reviewed Apr 5, 2021
View reviewed changes
redbot/cogs/streams/streams.py Outdated Show resolved Hide resolved
redbot/cogs/streams/streamtypes.py Outdated Show resolved Hide resolved
TrustyJAID
TrustyJAID approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@TrustyJAID TrustyJAID left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@Jackenmen Jackenmen merged commit 67fa735 into Cog-Creators:V3/develop Apr 5, 2021
@Jackenmen Jackenmen deleted the V3/use_partial_messages_in_streams branch April 5, 2021 19:39
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrustyJAID TrustyJAID TrustyJAID approved these changes

@palmtree5 palmtree5 Awaiting requested review from palmtree5 palmtree5 is a code owner

Assignees
No one assigned
Labels
Category: Cogs - Streams This is related to the Streams cog. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Type: Optimisation Situations where too much time is necessary to complete the task.
Projects
None yet
Milestone
3.4.8
Development

Successfully merging this pull request may close these issues.

Prevent possible leakage from discord.Message objects in Streams
2 participants
@Jackenmen @TrustyJAID