Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-869671bn4: Update requirements to fix workflow issue due to mypy #497

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Oct 15, 2024

Mypy update broke GHA.

This PR will attempt a fix.

First trivial change should result in failure.

Second change to pinned version (to lower than 1.12) should result in successful workflow.

@tomolopolis
Copy link
Member

Task linked: CU-869671bn4 Mypy update broke GHA

@mart-r mart-r changed the title CU-869671bn4: Update requirements (GHA should fail due to mypy) CU-869671bn4: Update requirements to fix workflow issue due to mypy Oct 16, 2024
Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mart-r mart-r merged commit 976adc2 into master Oct 28, 2024
8 checks passed
mart-r added a commit that referenced this pull request Nov 15, 2024
…497)

* CU-869671bn4: Update requirements (GHA should fail due to mypy)

* CU-869671bn4: Update mypy dev requirement to be less than 1.12
@mart-r mart-r deleted the CU-869671bn4-mypy-pin branch November 18, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants