CU-86967nnra Drop python 3.8 support (EoL) #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-86967nnra Drop support for python 3.8 (EoL) |
Upper bound could be lifted as soon as `spacy` releases a compatible versions. And it _shouldn't_ require any changes from our side. And it isn't possible to install it on higher versions (currently) due to no `spacy` being available for those versions
|
PS: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 is EoL since 7th of October. As such, it's time to stop support for it.
That is what this PR does. It:
python_requires='>=3.9'tosetup.pyto disallow installation older python versionsNOTE:
I considered adding a cap for newer python versions as well, but I didn't think it made sense in the large scheme of things since 3.12 support is held up behind
spacy3.12 support (which should be atspacy==2.4.0). It's not really under our control. It's also not currently possible to installmedcaton these newer python versions anyway (due to no compatiblespacy).