-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.2.1 #147
Release v2.2.1 #147
Conversation
Adjust `buf` in `discord_create_interaction_response()` to be the size of 16384 like the others
"Succesfully started a Discord session!" is missing a 's'
Adding the PostgreSQL & sqlite3 databases guides to Concord guides. Co-authored-by: HackerSmacker Co-authored-by: Lucas Müller <muller.lucas@hotmail.com>
…or Concord cross-compilation changes)
fix serializing for 'struct discord_request_guild_members' Part of #135
Fix for bug where websockets.c would try to send CLOSE to websocket when already disconnected in TLS errors Co-authored-by: Lucas Müller <lucas@muller.codes>
Adding the guide for the usage of the scheduler event, and how to parse the json from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is definitely a good documentation update, and, I think that the code updates are good.
A few things I've got on my roadmap for the future:
- my fixes to get Concord compiling on OpenVMS, just for fun
- drop dependence on CWS with a suitable replacement, not just a PoC
- add guides for "other" databases, such as MySQL and cloud DBs (as these are pretty popular nowadays)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Also, something that would be useful for the future would be a list of supported & unsupported things (like sharding), so new people won't be confused
Use QuerieC library to improve query system. Co-authored-by: Lucas Müller <lucas@muller.codes>
c8fa148
to
44f26a6
Compare
Bad typing for `resolved` object
Accessing a NULL ptr will segfault the bot, dealbreaker
Notice
to test it before making changes to Concord.
This PR introduces a couple of things:
Features
discord_shutdown_async()
, and adddiscord_shutting_down()
to check whether the client is currently in the process of shutting downBug fixes
NULL
check when convertingjson_char
types to JSONReferences
#140