Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.2.1 #147

Merged
merged 26 commits into from
Jul 8, 2023
Merged

Release v2.2.1 #147

merged 26 commits into from
Jul 8, 2023

Conversation

lcsmuller
Copy link
Collaborator

@lcsmuller lcsmuller commented May 14, 2023

Notice

  • I understand the code that I have edited, and have the means
    to test it before making changes to Concord.

This PR introduces a couple of things:

Features

  • Allow asynchronous shutdown via discord_shutdown_async(), and add discord_shutting_down() to check whether the client is currently in the process of shutting down
  • Add guides for:
    • Scheduler
    • PostgreSQL
    • running concord on weird systems
  • Bot tokens are now hidden from headers in the generated HTTP logs
  • Overall README improvements

Bug fixes

References

#140

HackerSmacker and others added 19 commits May 14, 2023 16:25
Adjust `buf` in `discord_create_interaction_response()` to be the size of 16384 like the others
"Succesfully started a Discord session!" is missing a 's'
Adding the PostgreSQL & sqlite3 databases guides to Concord guides.

Co-authored-by: HackerSmacker
Co-authored-by: Lucas Müller <muller.lucas@hotmail.com>
fix serializing for 'struct discord_request_guild_members'

Part of #135
Fix for bug where websockets.c would try to send CLOSE to websocket when already disconnected in TLS errors

Co-authored-by: Lucas Müller <lucas@muller.codes>
Adding the guide for the usage of the scheduler event, and how to parse the json from it.
@lcsmuller lcsmuller added the enhancement New feature or request label May 14, 2023
@lcsmuller lcsmuller changed the title [WIP] Release v2.3.0 [WIP] Release v2.2.1 May 14, 2023
@lcsmuller lcsmuller marked this pull request as ready for review May 14, 2023 19:50
@lcsmuller lcsmuller changed the title [WIP] Release v2.2.1 Release v2.2.1 May 14, 2023
@lcsmuller lcsmuller requested a review from ThePedroo May 14, 2023 19:55
Copy link
Collaborator

@HackerSmacker HackerSmacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is definitely a good documentation update, and, I think that the code updates are good.

A few things I've got on my roadmap for the future:

  • my fixes to get Concord compiling on OpenVMS, just for fun
  • drop dependence on CWS with a suitable replacement, not just a PoC
  • add guides for "other" databases, such as MySQL and cloud DBs (as these are pretty popular nowadays)

Copy link
Contributor

@ThePedroo ThePedroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Also, something that would be useful for the future would be a list of supported & unsupported things (like sharding), so new people won't be confused

Use QuerieC library to improve query system.

Co-authored-by: Lucas Müller <lucas@muller.codes>
@lcsmuller lcsmuller added the bug Something isn't working label Jun 9, 2023
@lcsmuller lcsmuller force-pushed the dev branch 2 times, most recently from c8fa148 to 44f26a6 Compare June 10, 2023 03:21
HackerSmacker and others added 2 commits June 13, 2023 12:57
@lcsmuller lcsmuller merged commit 769bdb7 into master Jul 8, 2023
@lcsmuller lcsmuller mentioned this pull request Sep 12, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants