Release v2.3.0 #181
Merged
Release v2.3.0 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter optional parameters from JSON encoding See: https://discord.com/developers/docs/resources/channel#modify-channel
Removed extra parameters from the discord_rest_run which were "added" on QuerieC PR. Co-authored-by: Lucas Müller <lucas@muller.codes> Co-authored-by: HackerSmacker <hackersmackertech@gmail.com>
Fix incorrect typing for `struct discord_roles`, it should be an array of role ids, rather than an array of `struct discord_role`
Use curl_free() in order to address scenarios where libcurl is using its custom mallocs which are incompatible with libc's
Completely remove lingering header node, previous node should point to the next
- Add string description for some missing error codes - Rename code enumerators that are in the same grouping
- Fix by changing status to `WS_DISCONNECTED` when TLS connection is ended, then avoid sending a request at `discord_gateway_perform()` by checking on the current websockets status
For debbuging unexpected TLS connection shutdowns
Ignore http_proxy env var
Should notify of abrupt disconnect only if current state is not WS_DISCONNECTING
This function is obsolete and the name causes problems when linking with OpenSSL statically.
* fix(gateway): not reconnecting on 1000 close codes This commit fixes the issue that it wouldn't reconnect on 1000 close codes. * fix(websockets): not calling on_close on TLS notify This commit fixes the issue that once a TLS notify was received, it wouldn't call on_close, ending up stuck in loop, not reconnecting. * fix(loop): not breaking loop on `DISCORD_SESSION_SHUTDOWN` This commit fixes an issue that the discord-loop loop wouldn't be breaken to reconnect, causing the bot to be stuck in the state of disconnected. * chore(websocket): update `already closed` ws message This commit updated the message that is printed to the terminal when a `ws_close` is called on a connection that has already ended. * revert(gateway): unnecessary cleanup This commit reverts a cleanup that is unnecessary as it's expected that `discord_cleanup` is called after `discord_run`. --------- Co-authored-by: Lucas Müller <lucas@muller.codes>
This commit fixes a memory leak that happened when a reason was set for some request.
This commit adds the check that verifies if the connection is dead, AKA zombie. Without this, once internet was unavailable for a certain time, Discord would stop responding to the heartbeats and wouldn't send any events, causing to the bot be offline, while the process would be still alive.
This fix is totally based off Anotra's PR commits #172, adapted to work on dev before the PR is merged.
|
Great! Can you follow the pattern of the PR from the latest release? |
|
You can bump the version to 2.3.0 |
ThePedroo
added
bug
lcsmuller
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
to test it before making changes to Concord.
This PR introduces a couple of things:
Features
Bug fixes
reasonoptiondiscord_role