feat: extract DynamicsSelector class #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redeboer
force-pushed
the
DynamicsSelector
branch
from
4303e46 to
41dd04f
Compare
redeboer
added a commit
that referenced
this pull request
Feb 23, 2022
* build: install singledispatchmethod * ci: deactivate fail-fast for unit testselow Python 3.8 * ci: test ampform with QRules v0.9.7 * docs: hide `__getitem__()` methods from API by default * docs: hide dict methods from API * feat: allow assigning dynamics by Particle instance * refactor: extract _HelicityModelIngredients class Co-authored-by: GitHub <noreply@github.com>
redeboer
added a commit
that referenced
this pull request
Feb 23, 2022
* build: install singledispatchmethod * ci: deactivate fail-fast for unit testselow Python 3.8 * ci: test ampform with QRules v0.9.7 * docs: hide `__getitem__()` methods from API by default * docs: hide dict methods from API * feat: allow assigning dynamics by Particle instance * refactor: extract _HelicityModelIngredients class Co-authored-by: GitHub <noreply@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HelicityAmplitudeBuilder.__dynamics_choiceshas been extracted to a newDynamicsSelectorclass. This reduces the responsibilities of theHelicityAmplitudeBuilderand makes it easier to implement new implementations for selection of dynamics.Something similar has been done for 'collector' attributes like
HelicityAmplitudeBuilder.__parameter_defaultsand__components. This will be useful when implementing TR-014, which will require keeping track of amplitude definitions.Note: once QRules v0.10 is out, ComPWA/qrules#156 and ComPWA/qrules#157 make it possible to define the dynamics choices as a mapping over topologies and visualize them as graphviz.